Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T2310: Make origin visits immutable
- Commits
- rDSTO312127af7ce3: storage*: Drop intermediary conversion step into OriginVisit
tox
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13214 Build 20176: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20175: arc lint + arc unit
Event Timeline
Build has FAILED
Patch application report for D3380 (id=11995)
Rebasing onto ffe6b9253e...
Current branch diff-target is up to date.
Changes applied before test
commit 350e6911fa6cff5d222f28701ce768c45a22bf75
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Jun 30 15:22:59 2020 +0200
storage*: Drop intermediary conversion step into OriginVisit
This is no longer possible as OriginVisit no longer hold the same information
as OriginVisitStatus.
This will allow to drop entirely those fields in the model.
Related to T2310Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/400/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/400/console
| swh/storage/algos/origin.py | ||
|---|---|---|
| 95 | "data" is uncountable | |
- Fix typo (thx)
- Drop the swh.model bump requirement (it's unneeded for the current diff change, so the build should be fine)
| swh/storage/algos/origin.py | ||
|---|---|---|
| 95 | yes, thx. | |
Really drop the swh.model version bump (i did update to 3.5 by mistake when
reverting manually :/)
Build was aborted
Patch application report for D3380 (id=11999)
Rebasing onto 953bd29ab0...
First, rewinding head to replay your work on top of it... Applying: storage*: Drop intermediary conversion step into OriginVisit
Changes applied before test
commit b031e7e4f3b674de6d0efe632fc635be6dec7b52
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Jun 30 15:22:59 2020 +0200
storage*: Drop intermediary conversion step into OriginVisit
This is no longer possible as OriginVisit no longer hold the same information
as OriginVisitStatus.
This will allow to drop entirely those fields in the model.
Related to T2310Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/401/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/401/console
Build was aborted
Patch application report for D3380 (id=12000)
Rebasing onto 953bd29ab0...
Current branch diff-target is up to date.
Changes applied before test
commit f218057b4413168bbab2166355cf7e178b3a6660
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Jun 30 15:22:59 2020 +0200
storage*: Drop intermediary conversion step into OriginVisit
This is no longer possible as OriginVisit no longer hold the same information
as OriginVisitStatus.
This will allow to drop entirely those fields in the model.
Related to T2310Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/402/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/402/console
Build was aborted
yes, i did, too many rebase following each other so no need for that many builds.
Build is green
Patch application report for D3380 (id=12001)
Rebasing onto 953bd29ab0...
Current branch diff-target is up to date.
Changes applied before test
commit 312127af7ce3a21287bae9cd5d3e2d124d577c6b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Jun 30 15:22:59 2020 +0200
storage*: Drop intermediary conversion step into OriginVisit
This is no longer possible as OriginVisit no longer hold the same information
as OriginVisitStatus.
This will allow to drop entirely those fields in the model.
Related to T2310See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/403/ for more details.