Differential D3372

Work around the segmentation faults caused by pytest-coverage + multiprocessing.
ClosedPublic
Actions

Authored by vlorentz on Jun 30 2020, 10:19 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO1f0e25615e9d: Work around the segmentation faults caused by pytest-coverage + multiprocessing.

Summary

We should probably report it to pytest-coverage, but I can't reproduce the bug outside swh-storage

Diff Detail

Repository

rDSTO Storage manager

Branch

pytest-cov-segfault

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13189
Build 20136: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20135: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 30 2020, 10:19 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 30 2020, 10:19 AM

vlorentz edited the summary of this revision. (Show Details)Jun 30 2020, 10:21 AM

fix typos

Build is green

Patch application report for D3372 (id=11970)

Rebasing onto dc1878b9fb...

Current branch diff-target is up to date.

Changes applied before test

commit 653be6556bbb80f9616bc53c7a944daede721aa0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 30 10:19:38 2020 +0200

    Work around the segmentation faults caused by pytest-coverage + multiprocessing.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/390/ for more details.

Harbormaster completed remote builds in B13188: Diff 11970.Jun 30 2020, 10:25 AM

It seems to make the build faster as well.

last green master build : 6m25s [1]
last green diff build: 5m0s [2]
And that seems steady across builds.

Let's give it a try then ;)

[1] https://jenkins.softwareheritage.org/job/DSTO/job/tests/1319
https://jenkins.softwareheritage.org/job/DSTO/job/tests/

#1319 6m25s
#1320 6m51s

[2] https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/390/
https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/
#390 5m0s
#391 5m20s

This revision is now accepted and ready to land.Jun 30 2020, 10:31 AM

Build is green

Patch application report for D3372 (id=11971)

Rebasing onto dc1878b9fb...

Current branch diff-target is up to date.

Changes applied before test

commit 1f0e25615e9ded8789921963abdd37b7d6eaaaf1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 30 10:19:38 2020 +0200

    Work around the segmentation faults caused by pytest-coverage + multiprocessing.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/391/ for more details.

Harbormaster completed remote builds in B13189: Diff 11971.Jun 30 2020, 10:31 AM

Closed by commit rDSTO1f0e25615e9d: Work around the segmentation faults caused by pytest-coverage + multiprocessing. (authored by vlorentz). · Explain WhyJun 30 2020, 10:57 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO1f0e25615e9d: Work around the segmentation faults caused by pytest-coverage + multiprocessing..