Page MenuHomeSoftware Heritage

templates/layout: Add a switch to toggle full width rendering
ClosedPublic

Authored by anlambert on Tue, Jun 16, 7:41 PM.

Details

Summary

Add a switch in the top left part of the UI in order to toggle full width
rendering of web application content.

This can be useful for high resolution screens or to extend the viewport width
for source code rendering.

The full width rendering state is also saved in browser local storage in order
to restore it on each web application page load.

Classic rendering:

Full width rendering:

Closes T2456

Test Plan

New cypress tests have been added.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Tue, Jun 16, 7:41 PM
anlambert updated this revision to Diff 11677.Tue, Jun 16, 7:44 PM

Update commit message

anlambert edited the summary of this revision. (Show Details)Tue, Jun 16, 7:44 PM

Build has FAILED

Patch application report for D3295 (id=11676)

Rebasing onto ab6de4ee83...

Current branch diff-target is up to date.
Changes applied before test
commit ce5dc738065dd057722755eb4c0b4eacba9771c2
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 16 19:40:34 2020 +0200

    templates/layout: Add a switch to toggle full width rendering
    
    Add a switch in the top left part of the UI in order to toggle full width
    rendering of web application content.
    
    This can be useful for high resolution screens or to extend the viewport width
    for source code rendering.
    
    Closes T2456

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/185/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/185/console

Build is green

Patch application report for D3295 (id=11677)

Rebasing onto ab6de4ee83...

Current branch diff-target is up to date.
Changes applied before test
commit 2740baa1ebf3196fa50e051f9cec19e1b9b4101f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 16 19:40:34 2020 +0200

    templates/layout: Add a switch to toggle full width rendering
    
    Add a switch in the top left part of the UI in order to toggle full width
    rendering of web application content.
    
    This can be useful for high resolution screens or to extend the viewport width
    for source code rendering.
    
    The full width rendering state is also saved in browser local storage in order
    to restore it on each web application page load.
    
    Closes T2456

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/186/ for more details.

ardumont accepted this revision.Tue, Jun 16, 8:13 PM
This revision is now accepted and ready to land.Tue, Jun 16, 8:13 PM