Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T2310: Make origin visits immutable
- Commits
- rDSTO46a78391ea46: test_storage: Add journal behavior coverage for origin-visit-*add
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- in-mem-orig-visit-status-add-idempotent
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12833 Build 19535: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 19534: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3279 (id=11626)
Could not rebase; Attempt merge onto 33efdb0dd4...
Updating 33efdb0..1ca3154 Fast-forward swh/storage/tests/test_storage.py | 165 +++++++++++++++----------------------- swh/storage/validate.py | 32 +++++--- 2 files changed, 86 insertions(+), 111 deletions(-)
Changes applied before test
commit 1ca31548ac6ae662e95de819bcdbc3eeb0f5aa6b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Jun 15 10:44:10 2020 +0200
test_storage: Add journal behavior coverage for origin-visit-*add
This was missing some coverage on origin-visit-add and origin-visit-status-add
for the journal part.
Related to T2310
commit 874da2dee1957ac5e9f5b17a81e11d9d9e8690f0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Sat Jun 13 08:37:57 2020 +0200
Start migrating the validate proxy toward using BaseModel objects
This will allow to progress incrementally towards removing it.
When it allows to use BaseModel objects everywhere (and tests in test_storage
are adapted to use this property), it will be time to remove it entirely (as
it's only used in test).
It's preparatory work for future diffs.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/274/ for more details.
| swh/storage/tests/test_storage.py | ||
|---|---|---|
| 1655 | ok on your remarks, i'll need to_dict here then, that'd be less code indeed ;) | |
Comment Actions
Adapt according to review
Also add a call to origin-visit-add to demonstrate its backend and journal
behavior (this on conflict, ignores the duplicates, but still send objects to
the journal)
Comment Actions
Build is green
Patch application report for D3279 (id=11627)
Could not rebase; Attempt merge onto 33efdb0dd4...
Updating 33efdb0..46a7839 Fast-forward swh/storage/tests/test_storage.py | 175 +++++++++++++++----------------------- swh/storage/validate.py | 32 ++++--- 2 files changed, 92 insertions(+), 115 deletions(-)
Changes applied before test
commit 46a78391ea46281619f6d39028b285e3450e9cde
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Jun 15 10:44:10 2020 +0200
test_storage: Add journal behavior coverage for origin-visit-*add
This was missing some coverage on origin-visit-add and origin-visit-status-add
for the journal part.
Related to T2310
commit 874da2dee1957ac5e9f5b17a81e11d9d9e8690f0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Sat Jun 13 08:37:57 2020 +0200
Start migrating the validate proxy toward using BaseModel objects
This will allow to progress incrementally towards removing it.
When it allows to use BaseModel objects everywhere (and tests in test_storage
are adapted to use this property), it will be time to remove it entirely (as
it's only used in test).
It's preparatory work for future diffs.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/275/ for more details.