Differential D3272

Adapt visit_date type from string to datetime
ClosedPublic
Actions

Authored by ardumont on Jun 12 2020, 11:30 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDLDG10376d5da4c9: Adapt visit_date type from string to datetime

Summary

This follows the latest loader changes. Now we deal only with visit_date as
datetime within the loader.

This should fix the master build which should fail at some point when triggered [1]

Related to T2310

[1] (manually triggered)
https://jenkins.softwareheritage.org/job/DLDG/job/tests/687/console

Test Plan

tox

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 12 2020, 11:30 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 12 2020, 11:30 AM

Build is green

Patch application report for D3272 (id=11597)

Rebasing onto 302c01e7c4...

Current branch diff-target is up to date.

Changes applied before test

commit 10376d5da4c900b21ce8dc21c064a83cfff31ce9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 12 10:10:53 2020 +0200

    Adapt visit_date type from string to datetime
    
    This follows the latest loader changes.
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/20/ for more details.

Harbormaster completed remote builds in B12802: Diff 11597.Jun 12 2020, 11:31 AM

ardumont edited the summary of this revision. (Show Details)Jun 12 2020, 11:33 AM

ardumont edited the summary of this revision. (Show Details)

vlorentz accepted this revision.Jun 12 2020, 11:41 AM

This revision is now accepted and ready to land.Jun 12 2020, 11:41 AM

Closed by commit rDLDG10376d5da4c9: Adapt visit_date type from string to datetime (authored by ardumont). · Explain WhyJun 12 2020, 11:56 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDG10376d5da4c9: Adapt visit_date type from string to datetime.