Differential D3266

assets, templates: Improve overall UI style
ClosedPublic
Actions

Authored by anlambert on Jun 11 2020, 7:04 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2318: Improve style for UI elements

Commits

rDWAPPS7d2742d531ac: assets, templates: Improve overall UI style

Summary

Set Bootstrap primary color to SWH theme red color and use Bootstrap custom
checboxes and radio buttons in order to get a nicer display of UI elements.

Before:

After:

Closes T2318

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 11 2020, 7:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 11 2020, 7:04 PM

anlambert added inline comments.Jun 11 2020, 7:07 PM

cypress/integration/origin-search.spec.js
80	Since the move to Bootstrap custom UI elements cypress was complaining that the checkbox label was covering the checkbox itself so force the check/uncheck operations as tests get flaky otherwise.

Update: Remove file that should not have been committed

Build is green

Patch application report for D3266 (id=11581)

Rebasing onto de0dfcb3b5...

Current branch diff-target is up to date.

Changes applied before test

commit 86ff84a6f8a5d685146029de74e3bf3b49f639f6
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 10 14:23:25 2020 +0200

    assets, templates: Improve overall UI style
    
    Set Bootstrap primary color to SWH theme red color and use Bootstrap custom
    checboxes and radio buttons in order to get a nicer display of UI elements.
    
    Closes T2318

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/168/ for more details.

Harbormaster completed remote builds in B12786: Diff 11581.Jun 11 2020, 7:14 PM

anlambert added a child revision: D3268: templates/homepage: Include origin search form at the top of the page.Jun 11 2020, 7:24 PM

Build has FAILED

Patch application report for D3266 (id=11582)

Rebasing onto de0dfcb3b5...

Current branch diff-target is up to date.

Changes applied before test

commit 279cdbd61b7d3f4e2a453fff8225f97362b400bc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 11 19:08:44 2020 +0200

    assets, templates: Improve overall UI style
    
    Set Bootstrap primary color to SWH theme red color and use Bootstrap custom
    checboxes and radio buttons in order to get a nicer display of UI elements.
    
    Closes T2318

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/169/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/169/console

Harbormaster failed remote builds in B12787: Diff 11582!Jun 11 2020, 7:25 PM

Build is green

Patch application report for D3266 (id=11582)

Rebasing onto de0dfcb3b5...

Current branch diff-target is up to date.

Changes applied before test

commit 279cdbd61b7d3f4e2a453fff8225f97362b400bc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 11 19:08:44 2020 +0200

    assets, templates: Improve overall UI style
    
    Set Bootstrap primary color to SWH theme red color and use Bootstrap custom
    checboxes and radio buttons in order to get a nicer display of UI elements.
    
    Closes T2318

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/173/ for more details.

Harbormaster completed remote builds in B12787: Diff 11582.Jun 11 2020, 8:07 PM

vlorentz accepted this revision.Jun 11 2020, 8:17 PM

This revision is now accepted and ready to land.Jun 11 2020, 8:17 PM

Rebase

Build is green

Patch application report for D3266 (id=11602)

Rebasing onto dc25295b05...

Current branch diff-target is up to date.

Changes applied before test

commit 7d2742d531ac7e89c11a4636fede12a5075a9c9e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 11 19:08:44 2020 +0200

    assets, templates: Improve overall UI style
    
    Set Bootstrap primary color to SWH theme red color and use Bootstrap custom
    checboxes and radio buttons in order to get a nicer display of UI elements.
    
    Closes T2318

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/179/ for more details.

Harbormaster completed remote builds in B12807: Diff 11602.Jun 12 2020, 12:23 PM

Closed by commit rDWAPPS7d2742d531ac: assets, templates: Improve overall UI style (authored by anlambert). · Explain WhyJun 12 2020, 2:18 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS7d2742d531ac: assets, templates: Improve overall UI style.