Page MenuHomeSoftware Heritage

browse/snapshot_context: Fix release retrieval for large snapshot
ClosedPublic

Authored by anlambert on Jun 5 2020, 5:30 PM.

Details

Summary

A release is looked up by its name and not its branch name in a snapshot.
For git origins, the branch name differs from the release name:
"/refs/tags/(release_name)".

So lookup for that type of branch name first and add fallback for release
name for other origin types.

Closes T2437

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-release-retrieval-large-snapshot
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12677
Build 19271: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19270: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 5 2020, 5:38 PM

Build is green

Patch application report for D3236 (id=11468)

Rebasing onto 7888549d8c...

Current branch diff-target is up to date.
Changes applied before test
commit 848be77285b71b1115aae4de98f8338e25b5647f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 5 15:57:09 2020 +0200

    browse/snapshot_context: Fix release retrieval for large snapshot
    
    A release is looked up by its name and not its branch name in a snapshot.
    For git origins, the branch name differs from the release name:
    "/refs/tags/(release_name)".
    
    So lookup for that type of branch name first and add fallback for release
    name for other origin types.
    
    Closes T2347

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/155/ for more details.

This revision was landed with ongoing or failed builds.Jun 5 2020, 5:43 PM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D3236 (id=11469)

Rebasing onto 1ebdb97c45...

First, rewinding head to replay your work on top of it...
Applying: browse/snapshot_context: Fix release retrieval for large snapshot
Changes applied before test
commit 4f332494737f304752c036de0f56d43ac3780645
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 5 15:57:09 2020 +0200

    browse/snapshot_context: Fix release retrieval for large snapshot
    
    A release is looked up by its name and not its branch name in a snapshot.
    For git origins, the branch name differs from the release name:
    "/refs/tags/(release_name)".
    
    So lookup for that type of branch name first and add fallback for release
    name for other origin types.
    
    Closes T2437

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/156/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/156/console

Build is green

Patch application report for D3236 (id=11472)

Rebasing onto 3e17ef162e...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-157-D3236.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/157/ for more details.