Paths

Table of Contentst

Differential D3230

scanner: nodes iteration function in model
ClosedPublic
Actions

Authored by DanSeraf on Jun 5 2020, 12:00 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDTSCN13ac68a9471e: model: iterate only the child nodes instead of the child nodes attributes

Summary

Since the iterate function could be useful to other methods it's better to have a general iterate function to get all the children nodes.

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Jun 5 2020, 12:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2020, 12:00 PM

Build is green

Patch application report for D3230 (id=11451)

Rebasing onto e126d2ac98...

Current branch diff-target is up to date.

Changes applied before test

commit 13ac68a9471e6c8edc64e975e75244c7d3863062
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Fri Jun 5 11:43:28 2020 +0200

    model: iterate only the child nodes instead of the child nodes attributes

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/26/ for more details.

Harbormaster completed remote builds in B12655: Diff 11451.Jun 5 2020, 12:03 PM

vlorentz accepted this revision.Jun 5 2020, 4:08 PM

This revision is now accepted and ready to land.Jun 5 2020, 4:08 PM

Closed by commit rDTSCN13ac68a9471e: model: iterate only the child nodes instead of the child nodes attributes (authored by DanSeraf). · Explain WhyJun 5 2020, 4:57 PM

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCN13ac68a9471e: model: iterate only the child nodes instead of the child nodes attributes.

Revision Contents
Changeset List

Path

Size

swh/

scanner/

model.py

22 lines

tests/

test_scanner.py

8 lines

Diff 11467

View Options

swh/scanner/model.py