Page MenuHomeSoftware Heritage

browse/content: Fix content path when not provided as query parameter
ClosedPublic

Authored by anlambert on Jun 4 2020, 3:44 PM.

Details

Summary

When browsing a legacy SWHID, a path field was included in the SWHID
displayed in the view but it should not as the information about it
is missing.

Closes T2427

Depends on D3223.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 4 2020, 3:44 PM
ardumont accepted this revision.Jun 4 2020, 4:09 PM
This revision is now accepted and ready to land.Jun 4 2020, 4:09 PM

Build is green

Patch application report for D3224 (id=11434)

Could not rebase; Attempt merge onto 3f9f08482c...

Updating 3f9f0848..904ed9d9
Fast-forward
 swh/web/browse/snapshot_context.py             |  44 +++--
 swh/web/browse/utils.py                        |  41 +++--
 swh/web/browse/views/content.py                |  68 ++++---
 swh/web/browse/views/directory.py              |  69 ++++---
 swh/web/browse/views/origin.py                 |  33 +++-
 swh/web/browse/views/release.py                |  21 ++-
 swh/web/browse/views/revision.py               |  66 ++++---
 swh/web/browse/views/snapshot.py               |   2 +-
 swh/web/common/identifiers.py                  |   2 +-
 swh/web/tests/browse/views/test_content.py     | 109 +++++++++++
 swh/web/tests/browse/views/test_directory.py   | 127 ++++++++++++-
 swh/web/tests/browse/views/test_identifiers.py |  48 ++++-
 swh/web/tests/browse/views/test_origin.py      | 136 +++++++++++---
 swh/web/tests/browse/views/test_release.py     |  83 ++++++---
 swh/web/tests/browse/views/test_revision.py    | 244 ++++++++++++++-----------
 15 files changed, 800 insertions(+), 293 deletions(-)
Changes applied before test
commit 904ed9d99b9f5c4c9522fda72310785fc5357430
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 4 14:08:49 2020 +0200

    browse/content: Fix content path when not provided as query parameter
    
    Closes T2427

commit 312db80743a7961b70cd31d581543e24eed4769b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 25 15:45:10 2020 +0200

    browse/revision: Fix revision id in snapshot context
    
    Closes T2417

commit 1d477dface8adc18ddf37ac48e370b7fdcd5426a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 3 19:40:04 2020 +0200

    browse: Add snapshot related query parameters in numerous object views
    
    It enables to browse archived objects scoped to a given origin visit, possibly
    on a given branch, release or revision.
    
    Related to T2342
    Related to T2427
    
    Closes T2359

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/148/ for more details.