Page MenuHomeSoftware Heritage

loader-core: Adapt build_revision implementation according to latest model api
ClosedPublic

Authored by ardumont on Jun 3 2020, 4:42 PM.

Details

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3217 (id=11408)

Rebasing onto 385843d863...

Current branch diff-target is up to date.
Changes applied before test
commit 29bf279ca58aac30e5956d035be2343d38b589c6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 3 16:41:07 2020 +0200

    Adapt build_revision implementation according to latest model api
    
    Related to D3177

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/59/ for more details.

ardumont retitled this revision from Adapt build_revision implementation according to latest model api to loader-core: Adapt build_revision implementation according to latest model api.Jun 3 2020, 4:45 PM
This revision is now accepted and ready to land.Jun 3 2020, 4:53 PM

Heads up, I won't merge it yet.

In the end (cf. irc), we are unsure about the current way forward (regarding the model change type from list to tuple and its impact).

Heads up, I won't merge it yet.

In the end (cf. irc), we are unsure about the current way forward (regarding the model change type from list to tuple and its impact).

It's the way forward, see D3218 so merging this ;)