Differential D3208

Force either revision or snapshot in generate_and_load_snapshot
ClosedPublic
Actions

Authored by olasd on Jun 2 2020, 6:50 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNa1a10d2da8e6: Force either revision or snapshot in generate_and_load_snapshot

Summary

Depends on D3204.

Test Plan

all tox tests still pass

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jun 2 2020, 6:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 2 2020, 6:50 PM

olasd mentioned this in D3204: Use loader_snapshot_id from swh.loader.core 0.1.0 instead of get_snapshot_id.Jun 2 2020, 6:52 PM

Build is green

Patch application report for D3208 (id=11385)

Rebasing onto f934581b20...

Current branch diff-target is up to date.

Changes applied before test

commit a1a10d2da8e6573009bb44a962025fb135918b35
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 2 18:48:11 2020 +0200

    Force either revision or snapshot in generate_and_load_snapshot

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/6/ for more details.

Harbormaster completed remote builds in B12584: Diff 11385.Jun 2 2020, 6:53 PM

Yes, sounds better.

That way we could investigate more on a particular case if that ever happens.

This revision is now accepted and ready to land.Jun 3 2020, 8:34 AM

Closed by commit rDLDSVNa1a10d2da8e6: Force either revision or snapshot in generate_and_load_snapshot (authored by olasd). · Explain WhyJun 3 2020, 10:06 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLDSVNa1a10d2da8e6: Force either revision or snapshot in generate_and_load_snapshot.

ardumont mentioned this in D3227: test_loader: assert returned loader status is what we expect.Jun 5 2020, 3:03 PM

ardumont mentioned this in P713 Altering history use case try to make a snapshot out of nothing.Jul 3 2020, 1:43 PM

ardumont mentioned this in D3410: tests: Refactor repository with tampered information scenario.Jul 3 2020, 1:55 PM

Revision Contents
Changeset List

Path

Size

swh/

loader/

svn/

loader.py

10 lines

Diff 11388

View Options

Force either revision or snapshot in generate_and_load_snapshotClosedPublicActions