This will allow us to run integration tests on the behavior of that method. This
also caught a tiny bug in the store_data method.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDLDBASE6fdb065fc767: Refactor DVCS loader tests to actually run the DVCSLoader store_data method
tox
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3200 (id=11357)
Could not rebase; Attempt merge onto faa138226d...
Updating faa1382..6fdb065 Fast-forward swh/loader/core/loader.py | 2 +- swh/loader/core/tests/test_loader.py | 37 ++++++++++++++++++++++++++---------- 2 files changed, 28 insertions(+), 11 deletions(-)
Changes applied before test
commit 6fdb065fc767d656430904dcd3581cedee19f35c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Fri May 29 14:36:41 2020 +0200
Refactor DVCS loader tests to actually run the DVCSLoader store_data method
This will allow us to run integration tests on the behavior of that method. This
also caught a tiny bug in the store_data method.
commit 326bc17070e637ceb1f35ecac37a95188d225341
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Fri May 29 14:55:00 2020 +0200
Make the test_loader origin a global variable to be able to reuse it later
commit cf98b1cb9b990966513551556caba34feff0561b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Fri May 29 14:55:30 2020 +0200
Drop useless fs mark on test that does not use any test fixturesSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/53/ for more details.
Comment Actions
If I split this in two commits, then either the first commit changes the tests (and is red), or the first commit changes the function (and it's not tested). So I'd rather keep the commit as a whole.