Page MenuHomeSoftware Heritage

Refactor local Makefile to run relevant things before tests/devserver
ClosedPublic

Authored by olasd on May 4 2018, 7:11 PM.

Details

Summary

The tests now depend on webpack being built, so do that before running make
test.

The devserver depends on migrations being run, so do that as well.

I'm not entirely sure the migration part is the right thing to do, but at least
with the webpack part, running the tests will do reasonable things.

Test Plan

make test still works

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Indeed, on a clean development environment, migrations (even if we do not use the orm part of django, this still needs to be executed at least one time if I recall correctly) and assets compilation must be executed for correctly running the tests. So let that diff land.

This revision is now accepted and ready to land.May 4 2018, 7:46 PM
This revision was automatically updated to reflect the committed changes.