Page MenuHomeSoftware Heritage

Make content.blake2s256 not null.
ClosedPublic

Authored by vlorentz on May 28 2020, 11:14 AM.

Details

Summary

There is no reason to allow null anymore; and the production DB
doesn't have any.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 28 2020, 11:14 AM

Build is green

Patch application report for D3190 (id=11332)

Could not rebase; Attempt merge onto 1aff3c6d15...

Updating 1aff3c6..fe877ce
Fast-forward
 sql/upgrades/151.sql              |  15 ++++++
 sql/upgrades/152.sql              |  11 ++++
 swh/storage/sql/30-swh-schema.sql |   4 +-
 swh/storage/sql/40-swh-func.sql   | 103 +-------------------------------------
 4 files changed, 29 insertions(+), 104 deletions(-)
 create mode 100644 sql/upgrades/151.sql
 create mode 100644 sql/upgrades/152.sql
Changes applied before test
commit fe877ce3a04c71b95a03d2eee1f8581eb3458570
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 28 11:14:10 2020 +0200

    Make content.blake2s256 not null.
    
    There is no reason to allow null anymore; and the production DB
    doesn't have any.

commit b0bff97191ba128fc1acfd8631ccdcaeac4d220b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 28 10:41:32 2020 +0200

    Remove unused SQL functions.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/200/ for more details.

ardumont accepted this revision.May 28 2020, 11:43 AM
This revision is now accepted and ready to land.May 28 2020, 11:43 AM
This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.May 28 2020, 2:08 PM
sql/upgrades/152.sql
11

I missed it (fixed alredy in master)

...
alter column blake2s256 setnot null;