Page MenuHomeSoftware Heritage

Pass collection + id to the checker instead of an URL.
ClosedPublic

Authored by vlorentz on May 5 2020, 3:48 PM.

Details

Summary

This allows the checker to use a configurable URL, in case it
needs an URL different from the one used by the client.

For example a client outside docker would use http://localhost:5080/deposit/
to access the API, but the checker cannot use this URL (it needs either
nginx or swh-deposit as hostname).

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 5 2020, 3:48 PM

Build has FAILED

Patch application report for D3124 (id=11097)

Rebasing onto cb6bc3aa57...

Current branch diff-target is up to date.
Changes applied before test
commit a5ba6735ccf169e4b3c8c6c54d57b06493064a3d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 5 15:48:01 2020 +0200

    Pass collection + id to the checker instead of an URL.
    
    This allows the checker to use a configurable URL, in case it
    needs an URL different from the one used by the client.
    
    For example a client outside docker would use http://localhost:5080/deposit/
    to access the API, but the checker cannot use this URL (it needs either
    nginx or swh-deposit as hostname).

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/14/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/14/console

vlorentz updated this revision to Diff 11099.May 5 2020, 4:16 PM

make tests pass

Build is green

Patch application report for D3124 (id=11099)

Rebasing onto cb6bc3aa57...

Current branch diff-target is up to date.
Changes applied before test
commit b7c2b6819e2717b2541ef36c2cbd4fd59c346f48
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 5 15:48:01 2020 +0200

    Pass collection + id to the checker instead of an URL.
    
    This allows the checker to use a configurable URL, in case it
    needs an URL different from the one used by the client.
    
    For example a client outside docker would use http://localhost:5080/deposit/
    to access the API, but the checker cannot use this URL (it needs either
    nginx or swh-deposit as hostname).

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/15/ for more details.

ardumont accepted this revision.May 5 2020, 5:17 PM
This revision is now accepted and ready to land.May 5 2020, 5:17 PM
vlorentz updated this revision to Diff 11113.Wed, May 6, 12:47 PM

update task signature

Build is green

Patch application report for D3124 (id=11113)

Rebasing onto cb6bc3aa57...

Current branch diff-target is up to date.
Changes applied before test
commit d2559583cafa67d7dc7a8e30ac7ca60c914151a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 5 15:48:01 2020 +0200

    Pass collection + id to the checker instead of an URL.
    
    This allows the checker to use a configurable URL, in case it
    needs an URL different from the one used by the client.
    
    For example a client outside docker would use http://localhost:5080/deposit/
    to access the API, but the checker cannot use this URL (it needs either
    nginx or swh-deposit as hostname).

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/16/ for more details.