Page MenuHomeSoftware Heritage

browse/release: Refactor metadata handling and add typing
ClosedPublic

Authored by anlambert on Apr 29 2020, 5:29 PM.

Details

Summary

Continue refactoring and typing archived objects metadata by processing release views.

Related to T2330

Depends on D3092.

Diff Detail

Repository
rDWAPPS Web applications
Branch
release-metadata-cleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12187
Build 18480: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18479: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 29 2020, 5:41 PM

Build is green

Patch application report for D3094 (id=11005)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..207dca9d
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  17 ++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/browse/views/release.py                    |  88 +++++-----
 swh/web/common/typing.py                           |  55 +++++++
 swh/web/templates/browse/release.html              |   2 +-
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 9 files changed, 271 insertions(+), 163 deletions(-)
Changes applied before test
commit 207dca9d848276abb7ef61c62b0c02d66ddf5ed3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:54:45 2020 +0200

    browse/release: Refactor metadata handling and add typing
    
    Related to T2330

commit bd8997e1061cb709a61436946bed6c2347d98cfa
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit c4f95517ebf3111f27d10e8522f23757a025f84e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit be38eb1abfe640562cb158cec5f8b81ec2ca2729
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/99/ for more details.

Build is green

Patch application report for D3094 (id=11011)

Could not rebase; Attempt merge onto c8bca2af35...

Merge made by the 'recursive' strategy.
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 +++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/browse/views/release.py                    |  88 +++++-----
 swh/web/common/typing.py                           |  55 +++++++
 swh/web/templates/browse/release.html              |   2 +-
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 9 files changed, 275 insertions(+), 163 deletions(-)
Changes applied before test
commit 28f653634446828ccd0743b4d58f51bf85e8e2f5
Merge: c8bca2af da6f9422
Author: Jenkins user <jenkins@localhost>
Date:   Wed Apr 29 17:54:23 2020 +0000

    Merge branch 'diff-target' into HEAD

commit da6f94224e9c7f5473189a0d5fce345c3930634e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:54:45 2020 +0200

    browse/release: Refactor metadata handling and add typing
    
    Related to T2330

commit 60016e97ed53b224a75a7c38a8a69a9d2af688c3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 8f118ab40bbf5ce8f209d3b3b798097122b78c57
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit cf53eb0d21f2674e480d99af4a699b695b56daa5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/103/ for more details.

Build is green

Patch application report for D3094 (id=11018)

Could not rebase; Attempt merge onto c8bca2af35...

Updating c8bca2af..aa735b93
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 +++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/browse/views/release.py                    |  88 +++++-----
 swh/web/common/typing.py                           |  55 +++++++
 swh/web/templates/browse/release.html              |   2 +-
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 9 files changed, 275 insertions(+), 163 deletions(-)
Changes applied before test
commit aa735b9339acb6179e8cbc9f8ad59638c9d513df
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:54:45 2020 +0200

    browse/release: Refactor metadata handling and add typing
    
    Related to T2330

commit 897d81f1b0dfbcc04e0bca554017db8cd3518461
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 7bbd64d4e63e3ed454aac0e07544e3845278625e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 51f2af1e78cddedea597bb8770d51da73a4352d7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/108/ for more details.