Differential D3050

pytest.ini: Avoid loading flask plugin to prevent fixture name clash
ClosedPublic
Actions

Authored by anlambert on Apr 23 2020, 2:53 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS98d53fedce7d: pytest.ini: Avoid loading flask plugin to prevent fixture name clash

Summary

pytest-django and pytest-flask both declare a fixture named client and
the wrong one is picked when running swh-web tests.

So avoid the loading of pytest flask plugin to prevent errors when
running tests.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12005
Build 18206: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18205: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 23 2020, 2:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 23 2020, 2:53 PM

ardumont accepted this revision.Apr 23 2020, 2:55 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

pytest.ini
2	out of curiosity, Is that a python option?

This revision is now accepted and ready to land.Apr 23 2020, 2:55 PM

anlambert added inline comments.Apr 23 2020, 3:00 PM

pytest.ini
2	nope, its a pytest option https://docs.pytest.org/en/latest/plugins.html#deactivating-unregistering-a-plugin-by-name

Build is green

Patch application report for D3050 (id=10850)

Rebasing onto 6945c4efa4...

Current branch diff-target is up to date.

Changes applied before test

commit 98d53fedce7d9f60e9577ecf97e4761b3fa9c112
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 14:50:03 2020 +0200

    pytest.ini: Avoid loading flask plugin to prevent fixture name clash
    
    pytest-django and pytest-flask both declare a fixture named client and
    the wrong one is picked when running swh-web tests.
    
    So avoid the loading of pytest flask plugin to prevent errors when
    running tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/80/ for more details.

Harbormaster completed remote builds in B12005: Diff 10850.Apr 23 2020, 3:00 PM

Closed by commit rDWAPPS98d53fedce7d: pytest.ini: Avoid loading flask plugin to prevent fixture name clash (authored by anlambert). · Explain WhyApr 23 2020, 3:01 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS98d53fedce7d: pytest.ini: Avoid loading flask plugin to prevent fixture name clash.

ardumont added inline comments.Apr 23 2020, 3:20 PM