Paths

Table of Contentst

Differential D3029

CLI: require explicit "-" to identify via stdin
ClosedPublic
Actions

Authored by zack on Apr 17 2020, 5:25 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDMOD7b2cc1fafd91: CLI: require explicit "-" to identify via stdin

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Apr 17 2020, 5:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 17 2020, 5:25 PM

Build is green

Patch application report for D3029 (id=10759)

Rebasing onto 6ac6cb7517...

Current branch diff-target is up to date.

Changes applied before test

commit 7b2cc1fafd9174369897668e760cd20134b2bab9
Author: Stefano Zacchiroli <zack@upsilon.cc>
Date:   Fri Apr 17 17:25:03 2020 +0200

    CLI: require explicit "-" to identify via stdin

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B11888: Diff 10759.Apr 17 2020, 5:26 PM

As suggested on IRC, you can just set required=True on @click.argument (and drop the if not objects:). But either way works.

This revision is now accepted and ready to land.Apr 17 2020, 5:30 PM

Closed by commit rDMOD7b2cc1fafd91: CLI: require explicit "-" to identify via stdin (authored by zack). · Explain WhyApr 17 2020, 5:47 PM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDMOD7b2cc1fafd91: CLI: require explicit "-" to identify via stdin.

Revision Contents
Changeset List

Path

Size

swh/

model/

cli.py

4 lines

tests/

test_cli.py

2 lines

Diff 10760

View Options

swh/model/cli.py