client: move subscription to a separate function
ClosedPublic
Actions

Authored by seirl on Apr 10 2020, 5:22 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDJNLb53d7d7c37ce: client: move subscription to a separate function

Summary

This allows overloading the subscribe() function, e.g for manual
assignment of partitions.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Apr 10 2020, 5:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2020, 5:22 PM

Build is green

Patch application report for D3013 (id=10691)

Rebasing onto 63bd07af49...

First, rewinding head to replay your work on top of it...
Applying: client: move subscription to a separate function

Changes applied before test

commit 443f1b0200b051b530c4d770012c3ee0f1f0f4d8
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Mar 19 12:34:26 2020 +0100

    client: move subscription to a separate function
    
    This allows overloading the subscribe() function, e.g for manual
    assignment of partitions.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/44/ for more details.

Harbormaster completed remote builds in B11812: Diff 10691.Apr 10 2020, 5:26 PM

I'm not sure about the self.subscription name but I can't think of a better one...

This revision is now accepted and ready to land.Apr 14 2020, 2:33 PM

rebase

This revision was landed with ongoing or failed builds.Apr 14 2020, 3:29 PM

Closed by commit rDJNLb53d7d7c37ce: client: move subscription to a separate function (authored by seirl). · Explain Why

This revision was automatically updated to reflect the committed changes.

seirl added a commit: rDJNLb53d7d7c37ce: client: move subscription to a separate function.

Build is green

Patch application report for D3013 (id=10724)

Rebasing onto 7ff372a02d...

Current branch diff-target is up to date.

Changes applied before test

commit b53d7d7c37ce7a3be6cb77216fcfe510bbeced08
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Mar 19 12:34:26 2020 +0100

    client: move subscription to a separate function
    
    This allows overloading the subscribe() function, e.g for manual
    assignment of partitions.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/47/ for more details.

Harbormaster completed remote builds in B11843: Diff 10724.Apr 14 2020, 3:35 PM