Makefile.python: make "make check" use pre-commit
ClosedPublic
Actions

Authored by zack on Apr 8 2020, 8:28 PM.

Details

Reviewers

Group Reviewers

Commits

rDENVc215d0e3f12a: Makefile.python: drop unused vars as well as check-staged
rDENV4fcc945cc859: Makefile.python: make "make check" use pre-commit

Summary

this reduces logic duplication, YAY!

Test Plan

make check in a repo of swh-environment of your choice

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Apr 8 2020, 8:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2020, 8:28 PM

Harbormaster completed remote builds in B11713: Diff 10608.Apr 8 2020, 8:28 PM

Please, also clean up the tool environment variables :)

This revision now requires changes to proceed.Apr 9 2020, 9:31 AM

Makefile.python: drop unused vars as well as check-staged

Harbormaster completed remote builds in B11739: Diff 10617.Apr 9 2020, 9:45 AM

Thanks.

This revision is now accepted and ready to land.Apr 9 2020, 9:45 AM

In D2984#72249, @ardumont wrote:

Please, also clean up the tool environment variables :)

Ah, good point, thanks. Done.

Note that I've now also removed check-staged, because I consider it subsumed by pre-commit too, as it will be run before the commit actually happens anyway.

Closed by commit rDENV4fcc945cc859: Makefile.python: make "make check" use pre-commit (authored by zack). · Explain WhyApr 9 2020, 9:46 AM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDENV4fcc945cc859: Makefile.python: make "make check" use pre-commit.

zack added a commit: rDENVc215d0e3f12a: Makefile.python: drop unused vars as well as check-staged.

One more step, I had to:

cd swh-environment
rm swh-*/.git/hooks/pre-commit.legacy

Revision Contents
Changeset List

Path

Size

Makefile.python

15 lines

Diff 10618

View Options

Makefile.python: make "make check" use pre-commitClosedPublicActions