Differential D2978

buffer: filter out duplicate objects.
ClosedPublic
Actions

Authored by vlorentz on Apr 8 2020, 12:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Diff Detail

Repository

rDSTO Storage manager

Branch

buffer-filter-duplicate

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11664
Build 17694: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17693: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 8 2020, 12:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2020, 12:03 PM

Build is green

Patch application report for D2978 (id=10577)

Rebasing onto 8e8577e8d4...

Current branch diff-target is up to date.

Changes applied before test

commit 1db2e58cef797134c6ebb816b9f7a4fa11ca11d8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 8 12:02:40 2020 +0200

    buffer: filter out duplicate objects.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/63/ for more details.

Harbormaster completed remote builds in B11664: Diff 10577.Apr 8 2020, 12:09 PM

ardumont accepted this revision.Apr 8 2020, 12:18 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/storage/buffer.py
127	(unrelated to the diff) was wondering why we flush everything and not the single object_type passed here. But that could make sense to flush everything indeed.