Page MenuHomeSoftware Heritage

test: update storage tests to (future) swh.journal 0.0.30
ClosedPublic

Authored by douardda on Apr 7 2020, 4:46 PM.

Details

Summary

which will handle swh.model objects everywhere instead of dicts.

Depends on D2970.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 7 2020, 4:46 PM

Build has FAILED

Patch application report for D2972 (id=10564)

Could not rebase; Attempt merge onto 82b41bac01...

Updating 82b41ba..9232c3c
Fast-forward
 setup.cfg                         |   6 +
 swh/storage/storage.py            |  12 +-
 swh/storage/tests/test_storage.py | 431 ++++++++++++++++++++------------------
 3 files changed, 239 insertions(+), 210 deletions(-)
 create mode 100644 setup.cfg
Changes applied before test
commit 9232c3c548cb66958e2e260b97119e165fb9417c
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:17:39 2020 +0200

    test: update storage tests to (future) swh.journal 0.0.30
    
    which will handle swh.model objects everywhere instead of dicts.

commit b6ebbec89795cecea575f34d70a12206a581bf1c
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:09:48 2020 +0200

    Make Storage.origin_visit_update() add an OriginVisit model entity in the journal
    
    instead of a dict, to comply with next version of swh.journal (which will
    require swh.model objects).

commit b7ad557128a504f9719acc08266d56fe40baf0a3
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:09:05 2020 +0200

    Make swh/storage/storage.py flake8 compliant

commit 5b711ecb275c032540663dd08b7c591ad409b12b
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:06:25 2020 +0200

    Add a setup.cfg file to configure flake8 for black compatibility

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/60/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/60/console

Build has FAILED

Patch application report for D2972 (id=10581)

Rebasing onto c51139ef96...

Current branch diff-target is up to date.
Changes applied before test
commit 4bb9a29f97ad3ac3b463bd363751644a16a451c9
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:17:39 2020 +0200

    test: update storage tests to (future) swh.journal 0.0.30
    
    which will handle swh.model objects everywhere instead of dicts.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/67/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/67/console

vlorentz accepted this revision.Apr 9 2020, 10:30 AM
This revision is now accepted and ready to land.Apr 9 2020, 10:30 AM
douardda updated this revision to Diff 10675.Apr 10 2020, 3:32 PM

rebase and improved to make it also compatible with swj.journal 0.0.29

Build is green

Patch application report for D2972 (id=10675)

Rebasing onto ddac3d27e3...

Current branch diff-target is up to date.
Changes applied before test
commit fd5ed546581506906dad640ba8c686a8ae754bbb
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:17:39 2020 +0200

    test: update storage tests to (future) swh.journal 0.0.30
    
    which will handle swh.model objects everywhere instead of dicts.
    
    Also add a BW compat version os the InMemoryJournalWriter so tests
    will pass with current version of swh.journal (0.0.29).

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/85/ for more details.

This revision was landed with ongoing or failed builds.Apr 14 2020, 11:39 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D2972 (id=10710)

Rebasing onto e5e594358b...

Current branch diff-target is up to date.
Changes applied before test
commit 2cc263da971e0c48f404f11a293031fffa8392fd
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:17:39 2020 +0200

    test: update storage tests to (future) swh.journal 0.0.30
    
    which will handle swh.model objects everywhere instead of dicts.
    
    Also add a BW compat version os the InMemoryJournalWriter so tests
    will pass with current version of swh.journal (0.0.29).

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/95/ for more details.