Page MenuHomeSoftware Heritage
Differential D2967

docker/conftest: Increase wait-for-it timeouts
ClosedPublic
Actions

Authored by anlambert on Apr 7 2020, 4:23 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDENV5bdffaf03067: docker/conftest: Increase wait-for-it timeouts
Summary

When running docker tests locally, some services can take some time to be up
so double associated wait-for-it timeouts

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 7 2020, 4:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2020, 4:23 PM
Harbormaster completed remote builds in B11647: Diff 10559.Apr 7 2020, 4:23 PM
douardda accepted this revision.Apr 7 2020, 4:51 PM
douardda added a subscriber: douardda.

why calling it _wfi_timeout (with the leading _)?

Also, in the glorious pytest way, this could be implemented as a fixture!

But yeah.

This revision is now accepted and ready to land.Apr 7 2020, 4:51 PM
anlambert added a comment.Apr 7 2020, 4:53 PM
In D2967#71861, @douardda wrote:

why calling it _wfi_timeout (with the leading _)?

Also, in the glorious pytest way, this could be implemented as a fixture!

But yeah.

Oh right, seems cleaner indeed. I will update before landing.

anlambert updated this revision to Diff 10565.Apr 7 2020, 5:25 PM

Update: use pytest fixture instead of private module variable

Harbormaster completed remote builds in B11653: Diff 10565.Apr 7 2020, 5:25 PM
Closed by commit rDENV5bdffaf03067: docker/conftest: Increase wait-for-it timeouts (authored by anlambert). · Explain WhyApr 7 2020, 5:28 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDENV5bdffaf03067: docker/conftest: Increase wait-for-it timeouts.

Revision Contents
Changeset List

PathSize
docker/
tests/
21 lines

Diff 10566

View Options

docker/tests/conftest.py

Loading...
About · Developer information · Legal