bin/update add support for (re)installing packages after update
ClosedPublic
Actions

Authored by zack on Mar 28 2020, 2:49 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDENVc7315fc145e6: bin/install: support user flags
rDENV6ea6f781090a: bin/update add support for (re)installing packages after update

Summary

after updating the repos it is often necessary to re-install packages
to take into account changes dependencies. This diff add support for doing
that, either as a standalone operation (bin/install) or together with repo
updating (bin/update --install).

I welcome feedback on whether, if this is accepted, we should update our doc at
https://docs.softwareheritage.org/devel/developer-setup.html to recommend using
bin/install instead of a manual pip command.

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Mar 28 2020, 2:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 28 2020, 2:49 PM

Harbormaster completed remote builds in B11440: Diff 10361.Mar 28 2020, 2:50 PM

lgtm

Just a couple of nitpicks.

bin/install
3	Should be pip3. And could you add `$@` at the end (so I can use `--user`)?

bin/install: support user flags

Harbormaster completed remote builds in B11442: Diff 10363.Mar 28 2020, 4:36 PM

zack added inline comments.Mar 28 2020, 4:36 PM

bin/install
3	Uhm, our developer setup assumes people are running within a (python3) virtualenv, so pip is OK, and also what we document. pip3 also works currently, but I'm not sure it will work in the long term. I'm assuming this request is for making things work also outside a virtualenv, but I'm not sure it's something we should recommend/support. Ack for "$@", added.