Details
Details
- Reviewers
zack - Maniphest Tasks
- T845: Failure mode for Vault tasks
- Commits
- rDVAU3a3c337107e6: Add failure state for bundle tasks
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Branch
- fail
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1151 Build 1495: arc lint + arc unit
Event Timeline
Comment Actions
LGTM. Just a couple of nits
swh/vault/backend.py | ||
---|---|---|
55 | i'd rather use a more neutral "we apologize for the inconvenience" here, to not encourage contacting us directly for every self-explanatory failure :) | |
318 | Couldn't status values other than 'done' and 'failed' trickle down here? Either way, I'd like to see an explicit test for status == 'failed' here, and possibly a 3rd if/else taking care of the other (unexpected) cases resulting in a assertion error or something such |