Differential D284

Add failure state for bundle tasks
ClosedPublic
Actions

Authored by seirl on Jan 10 2018, 5:30 PM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T845: Failure mode for Vault tasks

Commits

rDVAU3a3c337107e6: Add failure state for bundle tasks

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Jan 10 2018, 5:30 PM

Harbormaster completed remote builds in B1150: Diff 955.Jan 10 2018, 5:30 PM

seirl added a task: T845: Failure mode for Vault tasks.Jan 10 2018, 5:30 PM

LGTM. Just a couple of nits

swh/vault/backend.py
55	i'd rather use a more neutral "we apologize for the inconvenience" here, to not encourage contacting us directly for every self-explanatory failure :)
318	Couldn't status values other than 'done' and 'failed' trickle down here? Either way, I'd like to see an explicit test for status == 'failed' here, and possibly a 3rd if/else taking care of the other (unexpected) cases resulting in a assertion error or something such

This revision now requires changes to proceed.Jan 11 2018, 8:32 AM

seirl added inline comments.Jan 11 2018, 1:19 PM

swh/vault/backend.py
55	Good point, I wanted to change that but forgot.
318	This should only be called when the bundle is done or failed, but adding a condition+warning to make sure of that doesn't hurt.

update with zack's comments

Harbormaster completed remote builds in B1151: Diff 956.Jan 11 2018, 2:38 PM

seirl marked 4 inline comments as done.Jan 11 2018, 2:38 PM

zack accepted this revision.Jan 11 2018, 2:39 PM

This revision is now accepted and ready to land.Jan 11 2018, 2:39 PM

Closed by commit rDVAU3a3c337107e6: Add failure state for bundle tasks (authored by seirl). · Explain WhyJan 11 2018, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sql/

swh-vault-schema.sql

2 lines

swh/

vault/

73 lines

cookers/

17 lines

tests/

test_backend.py

36 lines

vault_testing.py

5 lines

Diff 957

sql/swh-vault-schema.sql

Loading...

swh/vault/backend.py

Loading...

swh/vault/cookers/base.py

Loading...

swh/vault/tests/test_backend.py

Loading...

swh/vault/tests/vault_testing.py

Loading...