Page MenuHomeSoftware Heritage

Add backwards-compatibility warning to msgpack_loads
ClosedPublic

Authored by olasd on Mar 11 2020, 2:07 PM.

Details

Summary

conversations on IRC reminded me that we should add this

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 11 2020, 2:07 PM
olasd added a comment.Mar 11 2020, 3:01 PM

Another thing we could do would be to inline these serialization/deserialization functions directly in swh.journal; that way that module can carry the bw-compat burden and the RPC layer can stay as efficient as possible.

ardumont accepted this revision.Mar 11 2020, 4:14 PM
This revision is now accepted and ready to land.Mar 11 2020, 4:14 PM
This revision was automatically updated to reflect the committed changes.