Page MenuHomeSoftware Heritage
Differential D2810

Add backwards-compatibility warning to msgpack_loads
ClosedPublic
Actions

Authored by olasd on Mar 11 2020, 2:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCOREa371a78adb7b: Add backwards-compatibility warning to msgpack_loads
Summary

conversations on IRC reminded me that we should add this

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 11 2020, 2:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 11 2020, 2:07 PM
swh-public-ci added a comment.Mar 11 2020, 2:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/430/ for more details.

Harbormaster completed remote builds in B11067: Diff 9995.Mar 11 2020, 2:09 PM
olasd added a comment.Mar 11 2020, 3:01 PM

Another thing we could do would be to inline these serialization/deserialization functions directly in swh.journal; that way that module can carry the bw-compat burden and the RPC layer can stay as efficient as possible.

ardumont accepted this revision.Mar 11 2020, 4:14 PM
This revision is now accepted and ready to land.Mar 11 2020, 4:14 PM
Closed by commit rDCOREa371a78adb7b: Add backwards-compatibility warning to msgpack_loads (authored by olasd). · Explain WhyMar 17 2020, 12:31 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDCOREa371a78adb7b: Add backwards-compatibility warning to msgpack_loads.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
7 lines

Diff 10100

View Options

swh/core/api/serializers.py

Loading...
About · Developer information · Legal