Differential D2786

Fix retry tests.
ClosedPublic
Actions

Authored by vlorentz on Mar 6 2020, 2:45 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO6fe9de4d601e: Fix retry tests.

Summary

mock_memory.has_calls does not exist; so calling it returns a MagicMock.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 6 2020, 2:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 6 2020, 2:45 PM

vlorentz planned changes to this revision.Mar 6 2020, 2:54 PM

fix more tests.

vlorentz added a child revision: D2787: Mock calls to time.sleep in retry tests..Mar 6 2020, 2:59 PM

mock_memory.has_calls does not exist; so calling it returns a MagicMock.

darn it, (T.T)

i read about that mistake somewhere...

Nice catch.

ardumont accepted this revision.Mar 6 2020, 3:14 PM

This revision is now accepted and ready to land.Mar 6 2020, 3:14 PM

This revision was landed with ongoing or failed builds.Mar 6 2020, 3:53 PM

Closed by commit rDSTO6fe9de4d601e: Fix retry tests. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO6fe9de4d601e: Fix retry tests..

Harbormaster failed remote builds in B10959: Diff 9891!Mar 6 2020, 3:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1026/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1026/console

Harbormaster failed remote builds in B10962: Diff 9892!Mar 6 2020, 3:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1027/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1027/console

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_retry.py

93 lines

Diff 9908

View Options

swh/storage/tests/test_retry.py

Fix retry tests.ClosedPublicActions