Page MenuHomeSoftware Heritage

scanner: check that pid exists before yield the sub path
ClosedPublic

Authored by DanSeraf on Mar 6 2020, 2:37 PM.

Diff Detail

Repository
rDTSCN Code scanner
Branch
check-get-pid
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10990
Build 16541: tox-on-jenkinsJenkins
Build 16540: arc lint + arc unit

Event Timeline

vlorentz requested changes to this revision.Mar 6 2020, 3:40 PM
vlorentz added a subscriber: vlorentz.

When does this happen? Could you add a test for this behavior?

This revision now requires changes to proceed.Mar 6 2020, 3:40 PM

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

Could you add this as a comment?

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

Could you add this as a comment?

Sure

This revision is now accepted and ready to land.Mar 6 2020, 5:09 PM

if a symbolic link is encountered, the persistent identifier is parsed by pid_of_file (as in swh.model)

if a symbolic link is encountered, the persistent identifier is parsed by pid_of_file (as in swh.model)

which means that the name of the target is used for hashing. That's ok with me.

This revision was landed with ongoing or failed builds.Mar 9 2020, 12:36 PM
This revision was automatically updated to reflect the committed changes.