Differential D2785

scanner: check that pid exists before yield the sub path
ClosedPublic
Actions

Authored by DanSeraf on Mar 6 2020, 2:37 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDTSCNb984695a79a8: scanner: behavior when a symlink is encountered

Diff Detail

Repository

rDTSCN Code scanner

Branch

check-get-pid

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10990
Build 16541: tox-on-jenkins	Jenkins
Build 16540: arc lint + arc unit

Event Timeline

DanSeraf created this revision.Mar 6 2020, 2:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 6 2020, 2:37 PM

Harbormaster completed remote builds in B10957: Diff 9890.Mar 6 2020, 2:37 PM

When does this happen? Could you add a test for this behavior?

This revision now requires changes to proceed.Mar 6 2020, 3:40 PM

In D2785#66553, @vlorentz wrote:

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

DanSeraf mentioned this in D2791: swh-scanner: integration tests.Mar 6 2020, 4:48 PM

In D2785#66602, @DanSeraf wrote:

In D2785#66553, @vlorentz wrote:

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

Could you add this as a comment?

DanSeraf added a child revision: D2791: swh-scanner: integration tests.Mar 6 2020, 4:51 PM

In D2785#66652, @vlorentz wrote:

In D2785#66602, @DanSeraf wrote:

In D2785#66553, @vlorentz wrote:

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

Could you add this as a comment?

Sure

comments

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/5/console

Harbormaster failed remote builds in B10990: Diff 9920!Mar 6 2020, 5:04 PM

vlorentz accepted this revision.Mar 6 2020, 5:09 PM

This revision is now accepted and ready to land.Mar 6 2020, 5:09 PM

if a symbolic link is encountered, the persistent identifier is parsed by pid_of_file (as in swh.model)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/7/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/7/console

Harbormaster failed remote builds in B10995: Diff 9924!Mar 9 2020, 12:30 PM

In D2785#66710, @DanSeraf wrote:

if a symbolic link is encountered, the persistent identifier is parsed by pid_of_file (as in swh.model)

which means that the name of the target is used for hashing. That's ok with me.

This revision was landed with ongoing or failed builds.Mar 9 2020, 12:36 PM

Closed by commit rDTSCNb984695a79a8: scanner: behavior when a symlink is encountered (authored by DanSeraf). · Explain Why

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCNb984695a79a8: scanner: behavior when a symlink is encountered.

Revision Contents
Changeset List

Path

Size

swh/

scanner/

6 lines

Diff 9920

swh/scanner/scanner.py

Loading...