Differential D2775
Do not cache requests for authenticated users Authored by anlambert on Mar 5 2020, 9:27 PM.
Details When using Django per site caching in production, requests are cached regardless Depends on D2747
Diff Detail
Event TimelineComment Actions Build is green Comment Actions Build is green Comment Actions Build is green Comment Actions Build is green Comment Actions Can't you do it just with this? MIDDLEWARE += ['swh.web.common.middlewares.HtmlMinifyMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.cache.FetchFromCacheMiddleware']According to https://docs.djangoproject.com/en/dev/topics/cache/#order-of-middleware , SessionMiddleware adds cookies to the Vary header, which should be taken into account by UpdateCacheMiddleware (and also by Varnish if it doesn't already) Comment Actions Just tested the middlewares reordering approach but it still does not work as expected, pages are still served from cache after login. This is clearly related to using a custom authentication backend because when using the default django one backed by a SQLite database, I would be tempted to remove this per site caching feature from Django as we already have a Varnish cache in production. Comment Actions Did you try calling [[https://docs.djangoproject.com/en/3.0/topics/http/sessions/#django.contrib.sessions.backends.base.SessionBase.cycle_key | request.session.cycle_key() ]] in the auth backend? It changes the session key, which changes the cookie, so it prevents reusing the same cache thanks to Vary. Comment Actions request.session.cycle_key() is already applied when calling django.contrib.auth.login in the oidc-login-complete view (I double checked by tracing the executed Django internal code). I need to dig a little further on this as I am convinced the observed cache issue can be resolved without the hack in that diff. Comment Actions Abandoning this as I could not reproduce the observed cache issue once the cookies associated to my development version of swh-web have been removed. To summarize, I got mistaken by my browsers cache. |