Page MenuHomeSoftware Heritage

Punch through the storage.objstorage "collaborator" to get to the actual objstorages
ClosedPublic

Authored by olasd on Mar 2 2020, 7:17 PM.

Details

Summary

This change introduced subtly confusing behavior, where the storage.objstorage
getattr proxy hides itself, until you try a dunder method (e.g. `foo in
storage.objstorage` or iter(storage.objstorage)), blows up in your face with a
confusing exception (because the collaborator is _also_ called ObjStorage).

Using the underlying objstorage works around that issue.

Test Plan

tox output is unchanged

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10852
Build 16310: tox-on-jenkinsJenkins
Build 16309: arc lint + arc unit