This actually fixes the debian build package failure [1]
I do not like it much as i'm fooling the extra serializer into my bidding. I do
not see a better way though, ideas welcome.
Also, i do not get why the tox build do not need it...
Details
Details
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10826 Build 16259: tox-on-jenkins Jenkins Build 16258: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1016/ for more details.
Comment Actions
LazyContents should not be going through the RPC layer. If they go through the RPC layer, then the data is lost.
One of the endpoints must be missing a call to .with_data().
Comment Actions
LazyContents should not be going through the RPC layer. If they go through the RPC layer, then the data is lost.
One of the endpoints must be missing a call to .with_data().
ok, i don't get it yet but i sense the logic in the reasoning. Looking for the missing call.
Thanks.
Comment Actions
The "lazy Content objects" were introduced when refactoring the swh.model.from_disk module.
The idea is to allow Content-like objects to be carried around in memory while having their full data loaded as late as possible; In the end, this should allow us to do the full pipeline of object existence checks with only hashes in memory, keeping the loading of data from disk to contents which we're going to need to transfer to storage anyway.
Of course there's lots of details that need to be sorted out (e.g. the lifetime of temporary files) before we can make full utilization of this feature in all loaders.
Currently, the storage RPC client should materialize lazy content objects by calling with_data before they're passed down the wire.
This needs a version of swh.core containing the following commit: rDCORE041728f8e4c9
Comment Actions
That's introduced in swh.core 0.0.94, this build was done with 0.0.93. We need to tighten our dependencies here.
Comment Actions
The "lazy Content objects" were introduced when refactoring the swh.model.from_disk module.
...
Thanks for the thorough explanation.
I kinda followed that from afar.
And did not grasp the relation ;)
That's introduced in swh.core 0.0.94, this build was done with 0.0.93. We need to tighten our dependencies here.
Yes indeed. I did fix the core, i must have triggered the storage one too soon.
(without updating the requirements indeed ;)
Closing this now and fixing the build appropriately ;)