indexer.metadata: Fix edge case on unknown origin
ClosedPublic
Actions

Authored by ardumont on Feb 25 2020, 2:56 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDXc6b6f760cc84: indexer.metadata: Fix edge case on unknown origin

Summary

storage.origin_get can return None as origin. This adds the behavior to skip
those None origins instead of failing the indexing task.

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 25 2020, 2:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/693/ for more details.

Harbormaster completed remote builds in B10753: Diff 9687.Feb 25 2020, 3:02 PM

ardumont edited the summary of this revision. (Show Details)Feb 26 2020, 10:26 AM

Rebase and plug on master

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/695/ for more details.

Harbormaster completed remote builds in B10763: Diff 9697.Feb 27 2020, 10:33 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2020, 10:35 AM

Closed by commit rDCIDXc6b6f760cc84: indexer.metadata: Fix edge case on unknown origin (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXc6b6f760cc84: indexer.metadata: Fix edge case on unknown origin.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata.py

2 lines

tests/

test_origin_metadata.py

8 lines

Diff 9698

View Options

swh/indexer/metadata.py