Optional[datetime]

not needed

?

why did you remove annotations?

please specify completely the type of the Generator

Optional[Dict[str, Any]]

not needed

missing return type

not needed

not needed

why the reformatting?

missing annotation

missing annotation

I added this return case because when I annotate the function mypy raise an error about a missing return case. So I think it's a better practice to manage all return cases, but if you prefer I can remove it and just put a "type ignore".

Indeed. Forget my comment then

I don't know how to fix it. Mypy saids that "Unsupported operand types for <= ("int" and "None")", but due to the if case this error should not occur, it's why I choose to ignore it. How can I fix it ?

This method returns always None in gnu/lister.py, so optional is needed.

because the line is 80.

I don't know how fix it, mypy saids unexpected type declaration when I try to annotate the line 119. And when I annotate params when defining, mypy doesn't take care of it and the error stays incompatible type assignement.

Oh indeed, I misunderstood the conditionals. You could do it like this to work around mypy:

if lower is None:
    if upper is None:
        ...
    else:
        ...
else:
    if upper is None:
        ...
    else:
        ...

(I also find this more readable, personally)

ok

What if you declare params like this?

params: Dict[str, Any] = {}

else, mypy assumes the type of params from the first value assignment, ie. params['headers'] = self.request_headers() or {}

you can use Iterator[str]

tbf, it's not that easy to determine the type now.

key seems to be mostly a string...
but then it's shadowed to something else (with maybe another type) used by sqlalchemy...
so mypy won't be happy unless we change the key names to something else in the body method.

The value could be anything.
And the return result is whatever sqlalchemy returns, a row of some sort...

So for me, the method is just missing a -> Any and it'd be fine as a first approximation.

@vlorentz ^ what do you think?

those are str except for c being an Optional[str] one