Page MenuHomeSoftware Heritage
Differential D2674

Force recooking of an object when previous vault task failed
ClosedPublic
Actions

Authored by anlambert on Feb 14 2020, 4:55 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS26c76934271c: assets/vault: Force recooking of an object when previous vault task failed
Summary

Previously, it was not offered to the user to recook an object when its last cooking failed.

So force object recooking by displaying the vault task creation modal.

Previous failed task will be also removed from the vault status page if it is present.

Related to T2283
Related to T2284

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 14 2020, 4:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 14 2020, 4:55 PM
swh-public-ci added a comment.Feb 14 2020, 5:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/950/ for more details.

vlorentz requested changes to this revision.Feb 14 2020, 5:13 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/assets/src/bundles/vault/vault-create-tasks.js
22–23

The comment doesn't match the code

swh/web/assets/src/bundles/vault/vault-ui.js
211

s/Statuses//?

This revision now requires changes to proceed.Feb 14 2020, 5:13 PM
swh-public-ci added a comment.Feb 14 2020, 5:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/559/ for more details.

Harbormaster completed remote builds in B10607: Diff 9546.Feb 14 2020, 5:46 PM
anlambert added inline comments.Feb 17 2020, 4:02 PM
swh/web/assets/src/bundles/vault/vault-create-tasks.js
22–23

Ack, will improve

swh/web/assets/src/bundles/vault/vault-ui.js
211

I will go for s/Statuses/Info/

anlambert updated this revision to Diff 9572.Feb 17 2020, 4:08 PM

Rebase and address @vlorentz comments

swh-public-ci added a comment.Feb 17 2020, 4:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/964/ for more details.

swh-public-ci added a comment.Feb 17 2020, 4:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/573/ for more details.

Harbormaster completed remote builds in B10633: Diff 9572.Feb 17 2020, 4:24 PM
vlorentz accepted this revision.Feb 18 2020, 2:12 PM
This revision is now accepted and ready to land.Feb 18 2020, 2:12 PM
anlambert updated this revision to Diff 9608.Feb 18 2020, 2:16 PM

Rebase

This revision was landed with ongoing or failed builds.Feb 18 2020, 2:17 PM
Closed by commit rDWAPPS26c76934271c: assets/vault: Force recooking of an object when previous vault task failed (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS26c76934271c: assets/vault: Force recooking of an object when previous vault task failed.
Harbormaster failed remote builds in B10669: Diff 9608!Feb 18 2020, 2:27 PM
swh-public-ci added a comment.Feb 18 2020, 2:27 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/972/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/972/console

swh-public-ci added a comment.Feb 18 2020, 2:49 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/581/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/581/console

Revision Contents
Changeset List

PathSize
cypress/
integration/
20 lines
swh/
web/
assets/
src/
bundles/
vault/
8 lines
17 lines

Diff 9609

View Options

cypress/integration/vault.spec.js

Loading...
View Options

swh/web/assets/src/bundles/vault/vault-create-tasks.js

Loading...
View Options

swh/web/assets/src/bundles/vault/vault-ui.js

Loading...
About · Developer information · Legal