There's a bunch of hardcoded sha1s sprinkled around that should probably be replaced by a global variable, but then again that's consistent with how things have been hardcoded at the swh-storage/swh-objstorage interface 🤦‍

I'll accept this as it makes the code cleaner anyway.

swh/vault/cookers/base.py
97	content is singular here -> has not been retrieved

This revision is now accepted and ready to land.Oct 20 2017, 5:58 PM

rebase + fix "content" singular

Harbormaster completed remote builds in B1063: Diff 863.Oct 23 2017, 3:40 PM

Closed by commit rDVAU062ebe8de84a: cookers: factor filtering of unavailable content (authored by seirl). · Explain WhyOct 23 2017, 3:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

vault/

cookers/

base.py

89 lines

revision_gitfast.py

4 lines

tests/

test_backend.py

8 lines

test_cookers.py

69 lines

vault_testing.py

7 lines

Diff 861

View Options

swh/vault/cookers/base.py

View Options

swh/vault/cookers/revision_gitfast.py

View Options

swh/vault/tests/test_backend.py

View Options

swh/vault/tests/test_cookers.py

View Options

swh/vault/tests/vault_testing.py

cookers: factor filtering of unavailable contentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 861

swh/vault/cookers/base.py

swh/vault/cookers/revision_gitfast.py

swh/vault/tests/test_backend.py

swh/vault/tests/test_cookers.py

swh/vault/tests/vault_testing.py

cookers: factor filtering of unavailable content
ClosedPublic
Actions

Revision Contents
Changeset List