Page MenuHomeSoftware Heritage
Differential D259

cookers: factor filtering of unavailable content
ClosedPublic
Actions

Authored by seirl on Oct 20 2017, 5:49 PM.

Details

Reviewers
olasd
Commits
rDVAU062ebe8de84a: cookers: factor filtering of unavailable content

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Oct 20 2017, 5:49 PM
Harbormaster completed remote builds in B1057: Diff 861.Oct 20 2017, 5:49 PM
olasd accepted this revision.Oct 20 2017, 5:58 PM
olasd added a subscriber: olasd.

There's a bunch of hardcoded sha1s sprinkled around that should probably be replaced by a global variable, but then again that's consistent with how things have been hardcoded at the swh-storage/swh-objstorage interface 🤦‍

I'll accept this as it makes the code cleaner anyway.

swh/vault/cookers/base.py
96

content is singular here -> has not been retrieved

This revision is now accepted and ready to land.Oct 20 2017, 5:58 PM
seirl updated this revision to Diff 863.Oct 23 2017, 3:40 PM

rebase + fix "content" singular

Harbormaster completed remote builds in B1063: Diff 863.Oct 23 2017, 3:40 PM
Closed by commit rDVAU062ebe8de84a: cookers: factor filtering of unavailable content (authored by seirl). · Explain WhyOct 23 2017, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
vault/
cookers/
89 lines
4 lines
tests/
8 lines
69 lines
7 lines

Diff 864

View Options

swh/vault/cookers/base.py

Loading...
View Options

swh/vault/cookers/revision_gitfast.py

Loading...
View Options

swh/vault/tests/test_backend.py

Loading...
View Options

swh/vault/tests/test_cookers.py

Loading...
View Options

swh/vault/tests/vault_testing.py

Loading...
About · Developer information · Legal