Differential D2538

Remove test_content_*_same_input, which check for behavior we do not want to guarantee.
ClosedPublic
Actions

Authored by vlorentz on Jan 16 2020, 3:30 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOCe5846554ad2b: Remove test_content_*_same_input, which check for behavior we do not want to…
rDSTOe5846554ad2b: Remove test_content_*_same_input, which check for behavior we do not want to…

Summary

They check that content_add deduplicates with existing content/duplicated
input.
This is unneeded (the loaders don't send such data), so providing these
guarantees unnecessarily complicates swh-storage code, especially the
upcoming Cassandra backend.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 16 2020, 3:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 16 2020, 3:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/859/ for more details.

Harbormaster completed remote builds in B10148: Diff 9042.Jan 16 2020, 3:33 PM

ok then.

This revision is now accepted and ready to land.Jan 17 2020, 11:26 AM

rebase

This revision was landed with ongoing or failed builds.Jan 17 2020, 3:10 PM

Closed by commit rDSTOe5846554ad2b: Remove test_content_*_same_input, which check for behavior we do not want to… (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOe5846554ad2b: Remove test_content_*_same_input, which check for behavior we do not want to….

Harbormaster failed remote builds in B10179: Diff 9108!Jan 17 2020, 3:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/865/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/865/console

vlorentz added a commit: rDSTOCe5846554ad2b: Remove test_content_*_same_input, which check for behavior we do not want to….Jan 17 2020, 4:28 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_storage.py

21 lines

Diff 9109

swh/storage/tests/test_storage.py

Loading...