Page MenuHomeSoftware Heritage

Remove test_content_*_same_input, which check for behavior we do not want to guarantee.
ClosedPublic

Authored by vlorentz on Jan 16 2020, 3:30 PM.

Details

Summary

They check that content_add deduplicates with existing content/duplicated
input.
This is unneeded (the loaders don't send such data), so providing these
guarantees unnecessarily complicates swh-storage code, especially the
upcoming Cassandra backend.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 16 2020, 3:30 PM
ardumont accepted this revision.Jan 17 2020, 11:26 AM
ardumont added a subscriber: ardumont.

ok then.

This revision is now accepted and ready to land.Jan 17 2020, 11:26 AM
This revision was landed with ongoing or failed builds.Jan 17 2020, 3:10 PM
This revision was automatically updated to reflect the committed changes.