Page MenuHomeSoftware Heritage
Differential D2536

svn.loader: Adapt with latest loader-core simplification
ClosedPublic
Actions

Authored by ardumont on Jan 15 2020, 3:12 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDSVN161f978a7c00: svn.loader: Adapt according to latest loader-core simplification
Summary

Related to D2535

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10134
Build 15030: tox-on-jenkinsJenkins
Build 15029: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 15 2020, 3:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2020, 3:12 PM
swh-public-ci added a comment.Jan 15 2020, 3:13 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/49/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/49/console

Harbormaster failed remote builds in B10125: Diff 9023!Jan 15 2020, 3:13 PM
ardumont updated this revision to Diff 9024.Jan 15 2020, 3:14 PM

Bump requirements for storage as well (for the retry behavior)

swh-public-ci added a comment.Jan 15 2020, 3:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/50/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/50/console

Harbormaster failed remote builds in B10126: Diff 9024!Jan 15 2020, 3:15 PM
ardumont updated this revision to Diff 9032.Jan 15 2020, 3:20 PM

Improve commit message (build will still fail)

swh-public-ci added a comment.Jan 15 2020, 3:21 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/51/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/51/console

Harbormaster failed remote builds in B10134: Diff 9032!Jan 15 2020, 3:21 PM
ardumont edited the test plan for this revision. (Show Details)Jan 15 2020, 3:37 PM
ardumont added inline comments.
swh/loader/svn/loader.py
62

got renamed (BufferedLoader still exists as alias) but it's the same behavior minus the retry and the send_* indirections.

swh-public-ci added a comment.Jan 15 2020, 3:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/52/ for more details.

Harbormaster completed remote builds in B10134: Diff 9032.Jan 15 2020, 3:39 PM
vlorentz accepted this revision.Jan 15 2020, 3:56 PM
This revision is now accepted and ready to land.Jan 15 2020, 3:56 PM
Closed by commit rDLDSVN161f978a7c00: svn.loader: Adapt according to latest loader-core simplification (authored by ardumont). · Explain WhyJan 15 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVN161f978a7c00: svn.loader: Adapt according to latest loader-core simplification.

Revision Contents
Changeset List

PathSize
4 lines
swh/
loader/
svn/
20 lines
tests/
7 lines

Diff 9032

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/svn/loader.py

Loading...
View Options

swh/loader/svn/tests/test_loader.py

Loading...
About · Developer information · Legal