Differential D2500

Use a page_token instead of an offset for origin search.
ClosedPublic
Actions

Authored by vlorentz on Jan 7 2020, 2:54 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS34cbe4ac9873: Use a page_token instead of an offset for origin search.

Summary

This currently does not change much, but will be needed to
support swh-search.

This will cause some temporary bug for users who click the Next button right after we deployed the upgrade, but it shouldn't be too bad.

Depends on D2499

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 7 2020, 2:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 7 2020, 2:54 PM

vlorentz edited the summary of this revision. (Show Details)Jan 7 2020, 2:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/866/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/473/ for more details.

Harbormaster completed remote builds in B9992: Diff 8893.Jan 7 2020, 3:03 PM

Looks good !

This revision is now accepted and ready to land.Jan 7 2020, 3:04 PM

Closed by commit rDWAPPS34cbe4ac9873: Use a page_token instead of an offset for origin search. (authored by vlorentz). · Explain WhyJan 7 2020, 3:08 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS34cbe4ac9873: Use a page_token instead of an offset for origin search..

Revision Contents
Changeset List

Path

Size

swh/

web/

api/

views/

origin.py

14 lines

common/

service.py

12 lines

Diff 8895

View Options

swh/web/api/views/origin.py