Page MenuHomeSoftware Heritage

package.loader: Fail loading early when failing to create an origin/visit
ClosedPublic

Authored by ardumont on Jan 6 2020, 2:14 PM.

Details

Summary

Fix [1] unbound value error when failure to create either origin or origin-visit.

[1] https://sentry.softwareheritage.org/share/issue/6c4750b56a114817bb088ec6e4965faf/

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 6 2020, 2:14 PM
ardumont retitled this revision from package.loader: Stop immediately loading when failing to create an origin/visit to package.loader: Fail loading early when failing to create an origin/visit.Jan 6 2020, 2:31 PM
ardumont updated this revision to Diff 8865.Jan 6 2020, 3:03 PM

Plug to fixture branch

ardumont edited the summary of this revision. (Show Details)Jan 6 2020, 3:06 PM
ardumont added a project: Core Loader.
ardumont updated this revision to Diff 8870.Jan 6 2020, 3:11 PM

Rebase on latest master

douardda accepted this revision.Jan 6 2020, 3:34 PM
douardda added inline comments.
swh/loader/package/loader.py
272

s/Failure/Failed/ ?

This revision is now accepted and ready to land.Jan 6 2020, 3:34 PM
ardumont updated this revision to Diff 8871.Jan 6 2020, 3:37 PM
  • Fix error message
  • plug to master branch
swh/loader/package/loader.py
272

yes