Page MenuHomeSoftware Heritage

package.loader: Fail loading early when failing to create an origin/visit
ClosedPublic

Authored by ardumont on Jan 6 2020, 2:14 PM.

Details

Summary

Fix [1] unbound value error when failure to create either origin or origin-visit.

[1] https://sentry.softwareheritage.org/share/issue/6c4750b56a114817bb088ec6e4965faf/

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9957
Build 14713: tox-on-jenkinsJenkins
Build 14712: arc lint + arc unit

Event Timeline

ardumont retitled this revision from package.loader: Stop immediately loading when failing to create an origin/visit to package.loader: Fail loading early when failing to create an origin/visit.Jan 6 2020, 2:31 PM
douardda added inline comments.
swh/loader/package/loader.py
271

s/Failure/Failed/ ?

This revision is now accepted and ready to land.Jan 6 2020, 3:34 PM
  • Fix error message
  • plug to master branch
swh/loader/package/loader.py
271

yes