Page MenuHomeSoftware Heritage

Consider the absence of --partial as an actionable command.
AbandonedPublic

Authored by vlorentz on Dec 17 2019, 6:56 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

Before this commit, it was impossible to finish a multipart
deposit without uploading a new archive or metadata file.

It should not happen if the upload was carefully planned,
but a human may realize at some point they don't have anything
else to upload.

Depends on D2464.

Diff Detail

Repository
rDDEP Push deposit
Branch
cli-actionable
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9870
Build 14573: tox-on-jenkinsJenkins
Build 14572: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 17 2019, 6:56 PM
vlorentz updated this revision to Diff 8773.Dec 18 2019, 7:07 PM

fix base commit

That works in test but does that work for real?

You can use the staging area to test this out by the way

swh/deposit/cli/client.py
216

I got a bit confused by this at first.
I think i'm better now...

swh/deposit/tests/cli/test_client.py
185

Same as slug/external_id shenanigans.

We have 2 terms for the same meaning, partial and in-progress deposit are the same thing.

Maybe we should think about unifying this once and for all as partial (choosing partial here because 1. it's shorter 2. it's public facing).
Again, not for now ;)

ardumont accepted this revision.Dec 19 2019, 9:05 AM
This revision is now accepted and ready to land.Dec 19 2019, 9:05 AM

That works in test but does that work for real?

Oops, it doesn't. Working on it

vlorentz closed this revision.Dec 19 2019, 2:55 PM

It's more trouble than I expected, so I'm not going to do it now.

vlorentz reopened this revision.Dec 19 2019, 2:55 PM
This revision is now accepted and ready to land.Dec 19 2019, 2:55 PM
vlorentz abandoned this revision.Dec 19 2019, 2:55 PM