Page MenuHomeSoftware Heritage
Differential D2430

loader.cli: Add 2 subcommands, one to load, one to introspect
ClosedPublic
Actions

Authored by ardumont on Dec 11 2019, 4:31 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDLDBASEaf185a4dfb39: loaders: Add missing class loader docstring
rDLDBASE2dc77128ec5d: test_cli: Test the cli list's standard use
rDLDBASE6be3534ad1ac: loader.cli: Improve current implementation
Summary

2 subcommands:

  • one to load: swh loader run <type> <url> <options>
  • one to list supported loader or instrospect the loader's extra arguments (most of the time url should be enough but not always) swh loader list swh loader list <type>

Related to T2134

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 11 2019, 4:31 PM
swh-public-ci added a comment.Dec 11 2019, 4:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/272/ for more details.

Harbormaster completed remote builds in B9679: Diff 8597.Dec 11 2019, 4:33 PM
vlorentz added a subscriber: vlorentz.Dec 11 2019, 4:35 PM

lgtm

swh/loader/cli.py
88

import at the top of the file please

ardumont added inline comments.Dec 12 2019, 11:00 AM
swh/loader/cli.py
88

mmmph, yeah!

ardumont updated this revision to Diff 8602.Dec 12 2019, 11:02 AM

Move import statement at the top of the file

swh-public-ci added a comment.Dec 12 2019, 11:04 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/274/ for more details.

Harbormaster completed remote builds in B9684: Diff 8602.Dec 12 2019, 11:04 AM
ardumont edited the summary of this revision. (Show Details)Dec 12 2019, 11:13 AM
ardumont updated this revision to Diff 8603.Dec 12 2019, 11:14 AM
  • loaders: Add missing class loader docstrings
  • test_cli: Test the cli list's standard use
swh-public-ci added a comment.Dec 12 2019, 11:15 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/275/ for more details.

Harbormaster completed remote builds in B9685: Diff 8603.Dec 12 2019, 11:15 AM
douardda accepted this revision.Dec 12 2019, 11:17 AM

Nice, thx

This revision is now accepted and ready to land.Dec 12 2019, 11:17 AM
Closed by commit rDLDBASE6be3534ad1ac: loader.cli: Improve current implementation (authored by ardumont). · Explain WhyDec 12 2019, 11:42 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASE6be3534ad1ac: loader.cli: Improve current implementation.
ardumont added a commit: rDLDBASEaf185a4dfb39: loaders: Add missing class loader docstring.
ardumont added a commit: rDLDBASE2dc77128ec5d: test_cli: Test the cli list's standard use.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
40 lines
tests/
42 lines

Diff 8605

View Options

setup.py

Loading...
View Options

swh/loader/cli.py

Loading...
View Options

swh/loader/tests/test_cli.py

Loading...
About · Developer information · Legal