Page MenuHomeSoftware Heritage

Add sentry integration to swh-web

Authored by vlorentz on Dec 10 2019, 2:06 PM.

Diff Detail

rDWAPPS Web applications
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 10 2019, 2:06 PM
vlorentz added inline comments.Dec 10 2019, 2:09 PM

note that I changed this to be stricted. But this block is wrapped in a larger except Exception as exc:, which will catch other exceptions, if any.


I did some refactoring here to capture only ImproperlyConfigured instead of all exceptions; and also to make the try block as short as possible to not catch too many errors.

vlorentz updated this revision to Diff 8569.Dec 10 2019, 2:26 PM
  • Work around pip's lack of a dependency resolver
  • Silence mypy about override of post_fork
vlorentz updated this revision to Diff 8571.Dec 10 2019, 2:42 PM

add tests for gunicorn_config.

anlambert added inline comments.
1 ↗(On Diff #8569)

The swh/web/settings folder is dedicated to contain Django configuration.

I think that file should be moved in the swh/web directory which already contains configuration related modules.

vlorentz updated this revision to Diff 8572.Dec 10 2019, 2:46 PM

move as requested.

anlambert accepted this revision.Dec 10 2019, 2:57 PM

Looks good to me !

This revision is now accepted and ready to land.Dec 10 2019, 2:57 PM
This revision was landed with ongoing or failed builds.Dec 10 2019, 5:58 PM
This revision was automatically updated to reflect the committed changes.