Page MenuHomeSoftware Heritage

celery: add 2 statsd probes for the runner and listener
ClosedPublic

Authored by douardda on Dec 4 2019, 10:58 AM.

Details

Summary
  • runner: counting the number of scheduled tasks,
  • listener: counting the number of processed events.

Related to T2133

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
t2133
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9515
Build 14004: tox-on-jenkinsJenkins
Build 14003: arc lint + arc unit

Event Timeline

douardda created this revision.Dec 4 2019, 10:58 AM
douardda updated this revision to Diff 8432.Dec 4 2019, 3:27 PM

rebased + rename statsd probes (-scheduler/+total)

ardumont accepted this revision.Dec 4 2019, 3:33 PM
ardumont added a subscriber: ardumont.

Looks good to me

swh/scheduler/celery_backend/listener.py
54

That could be the occasion to also have a counter for unhandled types (i have no idea how noisy that would be).
swh_listener_unhandled_event_total or something?

This revision is now accepted and ready to land.Dec 4 2019, 3:33 PM
douardda updated this revision to Diff 8435.Dec 4 2019, 4:18 PM

I said -scheduler !

douardda added inline comments.Dec 4 2019, 4:20 PM
swh/scheduler/celery_backend/listener.py
54

not sure we want to engage the fight with celery on this. Who knows how many event type may exists here?

douardda updated this revision to Diff 8436.Dec 4 2019, 4:37 PM

ok, let's keep _scheduler_ in probe names

also fix a stupid "typo"...