Paths

Table of Contentst

Differential D2392

Hide (so-called) errors "Local: No offset stored".
ClosedPublic
Actions

Authored by vlorentz on Dec 3 2019, 4:10 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDJNLdeb9ea065884: Hide (so-called) errors "Local: No offset stored".

Summary

We're all tired of them.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 3 2019, 4:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 3 2019, 4:10 PM

add missing hunk

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/313/ for more details.

Harbormaster completed remote builds in B9497: Diff 8421.Dec 3 2019, 4:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/314/ for more details.

Harbormaster completed remote builds in B9498: Diff 8422.Dec 3 2019, 4:14 PM

To future-proof this, I suggest switching the logic to have a map between error codes and log levels in the error_cb function; I'm sure we'll want to tune other messages, and I'd prefer mapping this to a debug level log message rather than silencing it completely.

vlorentz planned changes to this revision.Dec 9 2019, 8:59 AM

apply comment

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/315/ for more details.

Harbormaster completed remote builds in B9678: Diff 8596.Dec 11 2019, 3:57 PM

olasd accepted this revision.Dec 16 2019, 1:47 PM

This revision is now accepted and ready to land.Dec 16 2019, 1:47 PM

Closed by commit rDJNLdeb9ea065884: Hide (so-called) errors "Local: No offset stored". (authored by vlorentz). · Explain WhyDec 16 2019, 2:13 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDJNLdeb9ea065884: Hide (so-called) errors "Local: No offset stored"..

Revision Contents
Changeset List

Path

Size

swh/

journal/

17 lines

Diff 8689

swh/journal/client.py

Loading...