Page MenuHomeSoftware Heritage

core.cli: Add auto-register loader subcommand mechanism
AbandonedPublic

Authored by ardumont on Dec 3 2019, 2:30 PM.

Details

Reviewers
douardda
olasd
Group Reviewers
Reviewers
Summary

This allows to define loader subcommand to the current swh command mechanism.

Note: I did not find a suitable way to test this yet. I tried to test via patching
the pkg_resources.iter_entry_points but that fails one way or another.

Related to T2134

Test Plan

tox

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
add-loader-subcommand
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9486
Build 13950: tox-on-jenkinsJenkins
Build 13949: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 3 2019, 2:30 PM
ardumont edited the summary of this revision. (Show Details)Dec 3 2019, 2:32 PM
ardumont edited the summary of this revision. (Show Details)Dec 3 2019, 2:40 PM
ardumont updated this revision to Diff 8412.Dec 3 2019, 2:49 PM

Refactor a bit

Wondering if it's the right location now.

Maybe it'd be more adequate to add a subcommand in swh-loader-core.
Its main purpose being the loader subcommands registering step.

ardumont abandoned this revision.Dec 4 2019, 11:54 AM

Maybe it'd be more adequate to add a subcommand in swh-loader-core.
Its main purpose being the loader subcommands registering step.

Indeed.
After discussion with @douardda, we don't want that here but in the loader-core.