Page MenuHomeSoftware Heritage
Differential D2338

Update the README and ensure pre-commit is available in bin/update
ClosedPublic
Actions

Authored by douardda on Nov 22 2019, 12:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDENV99e40b70c0e9: Remove pythonpath.sh
rDENV9e44c9328d95: Update the README file for pre-commit based git hooks
rDENV84b78c6ab309: bin/update: ensure pre-commit is available

Diff Detail

Repository
rDENV Development environment
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9321
Build 13640: arc lint + arc unit

Event Timeline

douardda created this revision.Nov 22 2019, 12:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 22 2019, 12:07 PM
Harbormaster completed remote builds in B9321: Diff 8053.Nov 22 2019, 12:07 PM
douardda updated this revision to Diff 8054.Nov 22 2019, 12:10 PM

also remove pythonpath.sh

Harbormaster completed remote builds in B9323: Diff 8054.Nov 22 2019, 12:10 PM
ardumont added a subscriber: ardumont.Nov 22 2019, 12:14 PM
ardumont added inline comments.
README.md
21

your SWH

22

You can create it using venv, virtualenv wrapper tool like... or ...

31

In the example below, we will...

62

... scripts. To upgrade your old development environment, execute the following command...

bin/update
11

... is required. Please install it following the README.md instruction

?

ardumont requested changes to this revision.Nov 22 2019, 5:51 PM

For the sake of you seeing my update proposal ;)

This revision now requires changes to proceed.Nov 22 2019, 5:51 PM
douardda updated this revision to Diff 8085.Nov 25 2019, 3:00 PM

Rebase + typos/rewordings in the README file

Harbormaster completed remote builds in B9361: Diff 8085.Nov 25 2019, 3:00 PM
ardumont accepted this revision.Nov 25 2019, 3:19 PM
This revision is now accepted and ready to land.Nov 25 2019, 3:19 PM
Closed by commit rDENV84b78c6ab309: bin/update: ensure pre-commit is available (authored by douardda). · Explain WhyNov 26 2019, 10:33 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENV84b78c6ab309: bin/update: ensure pre-commit is available.
douardda added a commit: rDENV9e44c9328d95: Update the README file for pre-commit based git hooks.
douardda added a commit: rDENV99e40b70c0e9: Remove pythonpath.sh.

Revision Contents
Changeset List

PathSize
55 lines
bin/
6 lines

Diff 8053

View Options

README.md

Loading...
View Options

bin/update

Loading...
About · Developer information · Legal